Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDO-3281 pt 2: Remove TableName() funcs from v2 models #367

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

katiewelch
Copy link
Contributor

No description provided.

@katiewelch katiewelch requested a review from a team as a code owner November 21, 2023 20:17
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

No API changes detected

Copy link

Published image from b4158d2 (merge eff2e58):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v0.2.45-eff2e58

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #367 (b4158d2) into main (81ad492) will increase coverage by 0.16%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   68.52%   68.68%   +0.16%     
==========================================
  Files         157      157              
  Lines       10250    10226      -24     
==========================================
  Hits         7024     7024              
+ Misses       2740     2716      -24     
  Partials      486      486              
Files Coverage Δ
...internal/deprecated_models/v2models/app_version.go 74.48% <ø> (+1.48%) ⬆️
...k/internal/deprecated_models/v2models/changeset.go 12.12% <ø> (+0.07%) ⬆️
...rlock/internal/deprecated_models/v2models/chart.go 90.74% <ø> (+3.24%) ⬆️
...ternal/deprecated_models/v2models/chart_release.go 54.97% <ø> (+0.63%) ⬆️
...ternal/deprecated_models/v2models/chart_version.go 72.82% <ø> (+1.54%) ⬆️
...ternal/deprecated_models/v2models/ci_identifier.go 67.34% <ø> (+1.34%) ⬆️
...lock/internal/deprecated_models/v2models/ci_run.go 79.54% <ø> (+1.18%) ⬆️
...ock/internal/deprecated_models/v2models/cluster.go 76.74% <ø> (+1.74%) ⬆️
...al/deprecated_models/v2models/database_instance.go 73.07% <ø> (+1.82%) ⬆️
...internal/deprecated_models/v2models/environment.go 37.46% <ø> (+0.23%) ⬆️
... and 3 more

@katiewelch katiewelch merged commit bb3f7e8 into main Nov 27, 2023
15 checks passed
@katiewelch katiewelch deleted the DDO-3281-remove-table-name-functions-from-v2 branch November 27, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants