Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3289] Improve error text in deploy hook test routes #351

Merged

Conversation

jack-r-warren
Copy link
Contributor

-		errors.AbortRequest(ctx, err)
+		errors.AbortRequest(ctx, fmt.Errorf("error between Sherlock and GitHub: %w", err))

Testing

This case is fully covered by tests, updated them

Risk

None

@jack-r-warren jack-r-warren requested a review from a team as a code owner November 3, 2023 20:54
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

github-actions bot commented Nov 3, 2023

No API changes detected

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #351 (6fa1991) into main (a50dc51) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   65.60%   65.60%           
=======================================
  Files         151      151           
  Lines        8853     8853           
=======================================
  Hits         5808     5808           
  Misses       2636     2636           
  Partials      409      409           
Files Coverage Δ
...herlock/github_actions_deploy_hooks_v3_test_run.go 70.58% <100.00%> (ø)
...nal/api/sherlock/slack_deploy_hooks_v3_test_run.go 74.35% <100.00%> (ø)

Copy link

github-actions bot commented Nov 3, 2023

Published image from 6fa1991 (merge 5ef91d7):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v0.2.35-5ef91d7

@jack-r-warren jack-r-warren merged commit 4047f8a into main Nov 3, 2023
15 checks passed
@jack-r-warren jack-r-warren deleted the DDO-3289-deploy-hook-test-run-better-error-message branch November 3, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants