Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3290] Stop escaping text sent to Slack's API #350

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

jack-r-warren
Copy link
Contributor

@jack-r-warren jack-r-warren commented Nov 3, 2023

All the mocks in the world don't help if you're explicitly telling the Slack library to escape the all-important < and > characters. Whatever.

Screenshot 2023-11-03 at 12 43 40 PM

Testing

Well I dove into the library code to see that it was explicitly escaping "<" and ">". I don't know, I think trying to write tests around the library's outward HTTP behavior is more brittle than it is worth.

Risk

Very low.

@jack-r-warren jack-r-warren requested a review from a team as a code owner November 3, 2023 17:02
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

github-actions bot commented Nov 3, 2023

What's Deleted


POST /api/deploy-hooks/github-actions/procedures/v3/test/{selector}

Test a GithubActionsDeployHook

POST /api/deploy-hooks/slack/procedures/v3/test/{selector}

Test a SlackDeployHook

Copy link

github-actions bot commented Nov 3, 2023

Published image from 47a15b2 (merge 0dba80b):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v0.2.34-0dba80b

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #350 (47a15b2) into main (82aeff1) will increase coverage by 0.12%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   65.48%   65.60%   +0.12%     
==========================================
  Files         149      151       +2     
  Lines        8749     8853     +104     
==========================================
+ Hits         5729     5808      +79     
- Misses       2619     2636      +17     
- Partials      401      409       +8     
Files Coverage Δ
sherlock/internal/slack/send_message.go 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

@jack-r-warren jack-r-warren merged commit a50dc51 into main Nov 3, 2023
15 checks passed
@jack-r-warren jack-r-warren deleted the DDO-3290-no-escape branch November 3, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants