Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3272] Move metrics code out of deprecated folders #343

Merged
merged 16 commits into from
Oct 31, 2023

Conversation

jack-r-warren
Copy link
Contributor

Adapts the metrics-generation code to live outside the deprecated folders

Testing

Sherlock boots and generates metrics. It would scream if it couldn't, there's a test oo.

Risk

Very low

@jack-r-warren jack-r-warren requested a review from a team as a code owner October 30, 2023 16:25
Base automatically changed from DDO-3264-database-instance to main October 31, 2023 01:43
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

No API changes detected

Copy link

Published image from 86f6c94 (merge fd3ea3e):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v0.2.26-fd3ea3e

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #343 (86f6c94) into main (8729332) will increase coverage by 2.24%.
Report is 1 commits behind head on main.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   63.21%   65.46%   +2.24%     
==========================================
  Files         147      147              
  Lines        8683     8689       +6     
==========================================
+ Hits         5489     5688     +199     
+ Misses       2819     2599     -220     
- Partials      375      402      +27     
Files Coverage Δ
sherlock/internal/boot/application.go 59.34% <20.00%> (ø)
sherlock/internal/models/metrics_cron.go 48.28% <27.27%> (ø)

... and 1 file with indirect coverage changes

@jack-r-warren jack-r-warren merged commit 7b97747 into main Oct 31, 2023
15 checks passed
@jack-r-warren jack-r-warren deleted the move-metrics-cron branch October 31, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants