[DDO-3268] Bring back a bit of the old logging #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
No API changes detected |
Codecov Report
@@ Coverage Diff @@
## main #339 +/- ##
=======================================
Coverage 63.21% 63.21%
=======================================
Files 147 147
Lines 8683 8683
=======================================
Hits 5489 5489
Misses 2819 2819
Partials 375 375 |
mikeflinn
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay so I went a bit too far on the JSON-ifying, and now the GCP logs are kinda unreadable when you first open the page.
This tiny change just adds the most useful fields back to the message to improve readability in GCP.
Testing
I trigger this locally, here's a sample message content:
Risk
Very low