Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3225] Use v3 version endpoints from GHA #334

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

jack-r-warren
Copy link
Contributor

@jack-r-warren jack-r-warren commented Oct 16, 2023

  1. Convert the report workflows to use the v3 version endpoints
  2. To help test this, begin reporting Sherlock's own versions
  3. Improve the app version parent-finding behavior to handle monorepos (add --exclude='*/**' to the tag-finding code so that it won't see tags like go-shared/v1.2.3 as potential parents, only v1.2.3)
  4. Rename an internal Sherlock variable because I confused myself looking at the code
  5. Make Sherlock's build now run when GHA components of that action change to help test them more generally

Testing

Steps 2 and 5 above help test this

Risk

Low based on step 2 and confirming at https://beehive.dsp-devops.broadinstitute.org/charts/sherlock/app-versions/v0.2.16-8dd7531

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Published image from 8c4f473 (merge a4c03a7):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v0.2.16-a4c03a7

@github-actions
Copy link

No API changes detected

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jack-r-warren jack-r-warren marked this pull request as ready for review October 16, 2023 18:46
@jack-r-warren jack-r-warren requested a review from a team as a code owner October 16, 2023 18:46
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #334 (8c4f473) into main (1660cc4) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   63.23%   63.23%           
=======================================
  Files         147      147           
  Lines        8671     8671           
=======================================
  Hits         5483     5483           
  Misses       2813     2813           
  Partials      375      375           
Files Coverage Δ
sherlock/internal/api/sherlock/app_version_v3.go 70.83% <50.00%> (ø)
sherlock/internal/api/sherlock/chart_version_v3.go 71.73% <50.00%> (ø)

@jack-r-warren jack-r-warren merged commit 05db75f into main Oct 16, 2023
15 checks passed
@jack-r-warren jack-r-warren deleted the DDO-3225-version-v3-gha-usage branch October 16, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants