Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3219] Fix upsert API methods and add Swagger comment test #329

Merged
merged 5 commits into from
Oct 13, 2023
Merged

[DDO-3219] Fix upsert API methods and add Swagger comment test #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8684fb6
improve mock generation
jack-r-warren Oct 13, 2023
8597f28
add mock for IRoutes
jack-r-warren Oct 13, 2023
020a248
use IRoutes interface
jack-r-warren Oct 13, 2023
d8656c9
add failing test
jack-r-warren Oct 13, 2023
14e3314
fix
jack-r-warren Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ generate-swagger:
# To install mockery, `brew install mockery`
# (As a backup, use `go install github.com/vektra/mockery/[email protected]` but check https://github.com/vektra/mockery/releases for versions)
generate-mocks:
cd sherlock && go generate ./...
cd sherlock && mockery

# We use `go mod vendor` to package local dependencies in a way that the gcloud CLI can upload, but
# we don't keep that directory around because it'll confuse GoLand (we want our source of truth to be
Expand Down
5 changes: 5 additions & 0 deletions sherlock/.mockery.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ mockname: "Mock{{ .InterfaceNameCamel }}"
outpkg: "{{ .PackageName }}_mocks"

packages:
github.com/gin-gonic/gin:
interfaces:
IRoutes:
config:
dir: ./internal/api/gin_mocks
github.com/broadinstitute/sherlock/sherlock/internal/github:
interfaces:
mockableActionsClient:
Expand Down
Loading