Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDO-3201: chart version v3 API #321

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Conversation

katiewelch
Copy link
Contributor

No description provided.

@katiewelch katiewelch requested a review from a team as a code owner October 6, 2023 19:59
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

What's New


GET /api/chart-versions/procedures/v3/changelog

Get a changelog between two ChartVersions

GET /api/chart-versions/v3

List ChartVersions matching a filter

GET /api/chart-versions/v3/{selector}

Get an individual ChartVersion

PATCH /api/chart-versions/v3/{selector}

Edit an individual ChartVersion

POST /api/chartVersions/v3

Upsert a ChartVersion

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Published image from ef26765 (merge a90c75d):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v0.2.9-a90c75d

Copy link
Contributor

@jack-r-warren jack-r-warren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

sherlock/internal/api/sherlock/chart_version_v3.go Outdated Show resolved Hide resolved
sherlock/internal/api/sherlock/chart_version_v3.go Outdated Show resolved Hide resolved
sherlock/internal/api/sherlock/chart_version_v3_list.go Outdated Show resolved Hide resolved
sherlock/db/migrations/000058_chart_version_v3.down.sql Outdated Show resolved Hide resolved
sherlock/db/migrations/000058_chart_version_v3.up.sql Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #321 (53d4451) into main (04ae38d) will increase coverage by 0.47%.
Report is 1 commits behind head on main.
The diff coverage is 73.25%.

❗ Current head 53d4451 differs from pull request most recent head ef26765. Consider uploading reports for the commit ef26765 to get more accurate results

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   62.64%   63.11%   +0.47%     
==========================================
  Files         141      147       +6     
  Lines        8283     8611     +328     
==========================================
+ Hits         5189     5435     +246     
- Misses       2753     2807      +54     
- Partials      341      369      +28     
Files Coverage Δ
...rlock/internal/api/sherlock/app_version_v3_list.go 69.44% <100.00%> (ø)
sherlock/internal/api/sherlock/routes.go 100.00% <100.00%> (ø)
sherlock/internal/models/chart_version.go 92.98% <91.83%> (+67.98%) ⬆️
...ock/internal/api/sherlock/chart_version_v3_edit.go 63.33% <63.33%> (ø)
...ock/internal/api/sherlock/chart_version_v3_list.go 69.44% <69.44%> (ø)
...lock/internal/api/sherlock/chart_version_v3_get.go 76.00% <76.00%> (ø)
.../sherlock/chart_version_procedures_v3_changelog.go 71.15% <71.15%> (ø)
...k/internal/api/sherlock/chart_version_v3_upsert.go 58.33% <58.33%> (ø)
sherlock/internal/api/sherlock/chart_version_v3.go 71.01% <71.01%> (ø)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 27 Code Smells

No Coverage information No Coverage information
3.9% 3.9% Duplication

@katiewelch katiewelch merged commit 918e580 into main Oct 6, 2023
9 checks passed
@katiewelch katiewelch deleted the DDO-3201-chart-version-v3 branch October 6, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants