fix lint/test

broadinstitute · Jul 25, 2024 · 8a6f023 · 8a6f023
1 parent d6ba3aa
commit 8a6f023
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/sherlock/internal/api/sherlock/chart_releases_v3_test.go b/sherlock/internal/api/sherlock/chart_releases_v3_test.go
@@ -346,6 +346,7 @@ func (s *handlerSuite) TestChartReleaseV3_toModel() {
 }
 
 func Test_chartReleaseFromModel(t *testing.T) {
+	config.LoadTestConfig()
 	now := time.Now()
 	type args struct {
 		model models.ChartRelease

diff --git a/sherlock/internal/api/sherlock/environments_v3_test.go b/sherlock/internal/api/sherlock/environments_v3_test.go
@@ -311,6 +311,7 @@ func (s *handlerSuite) TestEnvironmentV3_toModel() {
 }
 
 func Test_environmentFromModel(t *testing.T) {
+	config.LoadTestConfig()
 	now := time.Now()
 	nowString := utils.TimePtrToISO8601(&now)
 	nowTimeParsedAgain, err := utils.ISO8601PtrToTime(nowString)

diff --git a/sherlock/internal/oidc_models/test_helper.go b/sherlock/internal/oidc_models/test_helper.go
@@ -38,6 +38,9 @@ func (h TestClientHelper) GenerateClient(db *gorm.DB) (clientID string, clientSe
 
 	clientSecretSalt := make([]byte, 32)
 	_, err = rand.Read(clientSecretSalt)
+	if err != nil {
+		return "", "", err
+	}
 
 	testClientHashIterations := 1_000 // Low low low value!!! Needs to be 210_000+ in production, this just makes tests run faster
 	clientSecretHash := pbkdf2.Key([]byte(clientSecret), clientSecretSalt, testClientHashIterations, 32, sha512.New)