Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-229:save a workflow message when aborting due to cost limit #3171

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Jan 23, 2025

Ticket: https://broadworkbench.atlassian.net/browse/CORE-229

When a workflow is aborted due to running over its cost limit, save a "Cost limit reached. Workflow was aborted to prevent cost overrun." message to that workflow. That message will be displayed in the Terra UI to indicate what happened with that workflow (this may require additional PRs)

As a bonus, I've addressed an outstanding TODO in the code where we were issuing db update … statements on every monitor pass for each workflow (if a cost cap was set), even if the workflow's cost and status hadn't changed.


PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and perform the corresponding dependency updates as specified in the README:
    • in the automation subdirectory
    • in workbench-libs
    • in firecloud-orchestration
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

@davidangb davidangb requested a review from a team as a code owner January 23, 2025 20:03
@davidangb davidangb requested review from dvoet and calypsomatic and removed request for a team January 23, 2025 20:03
@davidangb davidangb merged commit 5131bf8 into develop Jan 24, 2025
29 checks passed
@davidangb davidangb deleted the da_CORE-229_costLimitMessages branch January 24, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants