-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AJ-1797: Eliminate import-service integration from Rawls #2866
AJ-1797: Eliminate import-service integration from Rawls #2866
Conversation
9a8f66e
to
8a6817e
Compare
8c44683
to
8ce2fac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one syntax comment inline, otherwise looks good assuming it all works!
Sometime after this merges and releases, could you also remove the relevant configs from https://github.com/broadinstitute/terra-helmfile/blob/04becbb3707afe1c2b1bf31151961e3a541d4264/charts/rawls/templates/config/_conf.tpl#L182-L201 ?
As you commented in the description, I'd like to let cwds bake in prod for some days before committing this.
core/src/main/scala/org/broadinstitute/dsde/rawls/monitor/AvroUpsertMonitor.scala
Outdated
Show resolved
Hide resolved
Added and linked to https://github.com/broadinstitute/terra-helmfile/pull/5538 |
a6eb3c9
to
2365f08
Compare
2365f08
to
f889c01
Compare
f889c01
to
e3300d0
Compare
Remove import service. Once https://github.com/broadinstitute/terra-helmfile/pull/5556 is live, cWDS will effectively field 100% of import traffic and all import-service backend resources will be deactivated.
Ticket: AJ-1797
ImportServiceDAO
->CwdsDAO
to reflect that it now adapts only cWDS.Related PRs:
PR checklist
Make sure Swagger is updated if API changes(N/A)...and Orchestration's Swagger too!(N/A)If you changed anything in(N/A)model/
, then you should publish a new officialrawls-model
and updaterawls-model
in Orchestration's dependencies.