Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJ-1797: Eliminate import-service integration from Rawls #2866

Merged
merged 3 commits into from
May 24, 2024

Conversation

jladieu
Copy link
Contributor

@jladieu jladieu commented May 10, 2024

Remove import service. Once https://github.com/broadinstitute/terra-helmfile/pull/5556 is live, cWDS will effectively field 100% of import traffic and all import-service backend resources will be deactivated.

Ticket: AJ-1797

  • Shut off & remove all HTTP and pubsub interactions with ImportService which has been replaced by cWDS.
  • Rename ImportServiceDAO -> CwdsDAO to reflect that it now adapts only cWDS.

Related PRs:


PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes (N/A)
    • ...and Orchestration's Swagger too! (N/A)
  • If you changed anything in model/, then you should publish a new official rawls-model and update rawls-model in Orchestration's dependencies. (N/A)
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

@jladieu jladieu force-pushed the jl-aj-1797-stop-publishing-to-import-service branch 3 times, most recently from 9a8f66e to 8a6817e Compare May 10, 2024 20:53
@jladieu jladieu marked this pull request as draft May 10, 2024 20:59
@jladieu jladieu force-pushed the jl-aj-1797-stop-publishing-to-import-service branch 2 times, most recently from 8c44683 to 8ce2fac Compare May 13, 2024 16:42
@jladieu jladieu changed the title WIP: Attempt to prune import service AJ-1797: Eliminate import-service integration from Rawls May 13, 2024
@jladieu jladieu changed the title AJ-1797: Eliminate import-service integration from Rawls DO_NOT_MERGE: AJ-1797: Eliminate import-service integration from Rawls May 13, 2024
Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one syntax comment inline, otherwise looks good assuming it all works!

Sometime after this merges and releases, could you also remove the relevant configs from https://github.com/broadinstitute/terra-helmfile/blob/04becbb3707afe1c2b1bf31151961e3a541d4264/charts/rawls/templates/config/_conf.tpl#L182-L201 ?

As you commented in the description, I'd like to let cwds bake in prod for some days before committing this.

@jladieu
Copy link
Contributor Author

jladieu commented May 14, 2024

@jladieu jladieu force-pushed the jl-aj-1797-stop-publishing-to-import-service branch 2 times, most recently from a6eb3c9 to 2365f08 Compare May 20, 2024 19:47
@jladieu jladieu changed the title DO_NOT_MERGE: AJ-1797: Eliminate import-service integration from Rawls AJ-1797: Eliminate import-service integration from Rawls May 20, 2024
@jladieu jladieu marked this pull request as ready for review May 20, 2024 21:04
@jladieu jladieu requested a review from davidangb May 20, 2024 21:04
@jladieu jladieu force-pushed the jl-aj-1797-stop-publishing-to-import-service branch from 2365f08 to f889c01 Compare May 22, 2024 14:00
@jladieu jladieu force-pushed the jl-aj-1797-stop-publishing-to-import-service branch from f889c01 to e3300d0 Compare May 24, 2024 13:27
@jladieu jladieu merged commit 8192643 into develop May 24, 2024
28 checks passed
@jladieu jladieu deleted the jl-aj-1797-stop-publishing-to-import-service branch May 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants