CORE-165: restore TOS passthroughs #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
requested review from
dvoet and
kevinmarete
and removed request for
a team
Qi77Qi
approved these changes
Dec 19, 2024
davidangb
commented
Dec 19, 2024
| @@ -25,6 +25,7 @@ trait PassthroughApiService extends Directives with StreamingPassthrough { | |||
| pathPrefix("version" / "executionEngine")(streamingPassthrough(s"$rawls/version/executionEngine")), | |||
| // Sam | |||
| pathPrefix("api" / "proxyGroup")(streamingPassthrough(s"$sam/api/google/user/proxyGroup")), | |||
| pathPrefix("register" / "user")(streamingPassthrough(s"$sam/register/user")), | |||
| pathPrefix("register")(streamingPassthrough(s"$sam/register/user")), | |||
There was a problem hiding this comment.
This is ugly, but it allows:
| Orch | Sam |
|---|---|
| /register | /register/user |
| /register/user/v1/termsofservice | /register/user/v1/termsofservice |
marctalbott
approved these changes
Dec 19, 2024
dvoet
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1517 broke the terms-of-service passthroughs; this restores them.
Have you read CONTRIBUTING.md lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:
In all cases: