Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-165: /api/workspaces passthroughs #1507

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Dec 5, 2024

see previous PR at #1484

This PR adds a streamingPassthrough for /api/workspaces to Rawls, and removes all pre-existing passthrough routes which it supersedes.

This includes some important APIs such as:

  • get/create workspace
  • list/create submissions
  • query data table entities
  • checkBucketReadAccess

swat tests, which use those APIs, are passing. I've also manually smoke-tested this in a BEE.


Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge. Make sure your branch deletes; GitHub should do this for you.
  • Test this change deployed correctly and works on dev environment after deployment

@davidangb davidangb marked this pull request as ready for review December 11, 2024 20:14
@davidangb davidangb requested a review from a team as a code owner December 11, 2024 20:14
@davidangb davidangb requested review from dvoet and calypsomatic and removed request for a team December 11, 2024 20:14
@davidangb davidangb merged commit ac963be into develop Dec 16, 2024
13 checks passed
@davidangb davidangb deleted the da_CORE-165_passthroughs branch December 16, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants