Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-191: list/get/create import jobs works for requester-pays workspace #1502

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Nov 26, 2024

Creating, getting, and listing async data table import jobs did not work in requester-pays workspaces.

As part of these operations, Orchestration queries Rawls. It sends a workspace namespace+name, gets a response, and extracts the workspaceId from the response. However, the request it sent was for the entire workspace object, including bucket info. This would cause the request to fail for RP workspaces.

This PR introduces a new, optimized getWorkspaceId method for Orch to query Rawls. This request does not ask anything about buckets and therefore hits no problems in RP workspaces.


Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge. Make sure your branch deletes; GitHub should do this for you.
  • Test this change deployed correctly and works on dev environment after deployment

@@ -200,7 +200,7 @@ class MockRawlsDAO extends RawlsDAO {
private val rawlsWorkspaceWithAttributes = WorkspaceDetails(
"attributes",
"att",
"id",
"00000000-0000-0000-0000-000000000000",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to update this example test data; UUID.fromString("id") would cause problems. This is more realistic test data anyway.

@davidangb davidangb changed the title list/get import job in requester-pays workspace list/get/create import jobs works for requester-pays workspace Nov 26, 2024
@davidangb davidangb changed the title list/get/create import jobs works for requester-pays workspace CORE-191: list/get/create import jobs works for requester-pays workspace Nov 26, 2024
@davidangb davidangb marked this pull request as ready for review November 26, 2024 17:36
@davidangb davidangb requested a review from a team as a code owner November 26, 2024 17:36
@davidangb davidangb merged commit c1c78b4 into develop Nov 26, 2024
13 checks passed
@davidangb davidangb deleted the da_getWorkspaceFieldSpecs branch November 26, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants