Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ID-1112] Update workbench libs Dependencies.scala #1316

Merged
merged 3 commits into from
Mar 20, 2024
Merged

[ID-1112] Update workbench libs Dependencies.scala #1316

merged 3 commits into from
Mar 20, 2024

Conversation

samanehsan
Copy link
Contributor

@samanehsan samanehsan commented Mar 19, 2024 •
edited
Loading

<your comments for this PR go here>

Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes (No breaking changes)
  • I've updated the RC_XXX release ticket with any manual steps required to release this change (N/A)
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing (N/A)

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment

Ghost-in-a-Jar
Ghost-in-a-Jar reviewed Mar 20, 2024
View reviewed changes
project/Dependencies.scala Outdated
@@ -6,7 +6,7 @@ object Dependencies {
val jacksonV = "2.13.5"
val jacksonHotfixV = "2.13.5" // for when only some of the Jackson libs have hotfix releases
val nettyV = "4.1.107.Final"
val workbenchLibsHash = "1c0cf92" // see https://github.com/broadinstitute/workbench-libs readme for hash values
val workbenchLibsHash = "0923d9d8-SNAP" // see https://github.com/broadinstitute/workbench-libs readme for hash values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the workbenchLibs pr merges and publishes youll want to update this with the latest non-snapshot version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

Ghost-in-a-Jar
Ghost-in-a-Jar approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@Ghost-in-a-Jar Ghost-in-a-Jar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comment

@samanehsan samanehsan merged commit 5840c40 into develop Mar 20, 2024
13 checks passed
@samanehsan samanehsan deleted the se/ID-1112-add-oauth2-logout branch March 20, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghost-in-a-Jar Ghost-in-a-Jar Ghost-in-a-Jar approved these changes

@tlangs tlangs tlangs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samanehsan @tlangs @Ghost-in-a-Jar