Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJ-1602: use setBearerToken instead of setAccessToken for cWDS #1309

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Mar 14, 2024

cWDS client needs to use setBearerToken instead of setAccessToken.

See also:
DataBiosphere/terra-workspace-data-service#389
DataBiosphere/terra-workspace-data-service#335


Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the RC_XXX release ticket with any manual steps required to release this change
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment

Copy link

@yuliadub yuliadub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one keeps getting us! thanks for catching it!

@davidangb davidangb merged commit beab1ce into develop Mar 14, 2024
14 checks passed
@davidangb davidangb deleted the da_AJ-1602_bearerToken branch March 14, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants