Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJ-1683: update to latest workbench-libs and remove jose4j override #1306

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Mar 12, 2024


Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the RC_XXX release ticket with any manual steps required to release this change
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment

@davidangb davidangb marked this pull request as ready for review March 12, 2024 21:25
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.31%. Comparing base (664506a) to head (25e8bfb).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1306      +/-   ##
===========================================
+ Coverage    69.29%   69.31%   +0.02%     
===========================================
  Files           97       97              
  Lines         3407     3406       -1     
  Branches       368      369       +1     
===========================================
  Hits          2361     2361              
+ Misses        1046     1045       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidangb davidangb merged commit c083d6b into develop Mar 13, 2024
16 checks passed
@davidangb davidangb deleted the da_AJ-1683_jose4j branch March 13, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants