AJ-1485: remove compile-time warnings #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
commented
Dec 4, 2023
| @@ -37,7 +37,7 @@ class RegisterService(val rawlsDao: RawlsDAO, val samDao: SamDAO, val thurloeDao | |||
| _ <- thurloeDao.saveKeyValues(registrationResultUserInfo, Map("isRegistrationComplete" -> Profile.currentVersion.toString)) | |||
| _ <- if (!registerResult.allowed) { | |||
| thurloeDao.saveKeyValues(registrationResultUserInfo, Map("email" -> userInfo.userEmail)) | |||
| } else Future.successful() | |||
| } else Future.successful(()) | |||
There was a problem hiding this comment.
the compile warning was:
[warn] /Users/davidan/work/src/firecloud-orchestration/src/main/scala/org/broadinstitute/dsde/firecloud/service/RegisterService.scala:40:31: adaptation of an empty argument list by inserting () is deprecated: this is unlikely to be what you want
[warn] signature: Future.successful[T](result: T): scala.concurrent.Future[T]
[warn] given arguments: <none>
[warn] after adaptation: Future.successful((): Unit)
[warn] } else Future.successful()
[warn] ^
davidangb
commented
Dec 4, 2023
| @@ -35,7 +35,7 @@ class HttpGoogleServicesDAOSpec extends AnyFlatSpec with Matchers with PrivateMe | |||
| val testProject = "broad-dsde-dev" | |||
| val priceListUrl = ConfigFactory.load().getString("googlecloud.priceListUrl") | |||
| val defaultPriceList = GooglePriceList(GooglePrices(Map("us" -> BigDecimal(-0.11)), UsTieredPriceItem(Map(1L -> BigDecimal(-0.22)))), "v1", "1") | |||
| implicit val system = ActorSystem("HttpGoogleCloudStorageDAOSpec") | |||
| implicit val system: ActorSystem = ActorSystem("HttpGoogleCloudStorageDAOSpec") | |||
There was a problem hiding this comment.
this - and the remainder of the changes in this PR - had compile warnings of:
Implicit definition should have explicit type
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1254 +/- ##
========================================
Coverage 69.34% 69.34%
========================================
Files 97 97
Lines 3402 3402
Branches 372 372
========================================
Hits 2359 2359
Misses 1043 1043 ☔ View full report in Codecov by Sentry. |
yuliadub
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my laptop, before this PR,
sbt clean testreported 7 compile warnings. After this PR, it reports 0. This PR should not change any functionality, it just cleans up code.Have you read CONTRIBUTING.md lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:
In all cases: