Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): fix_memory error with adding new env #6879

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

lirshindalman
Copy link
Contributor

@lirshindalman lirshindalman commented Nov 27, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Address a memory error when adding new environments by refining the evaluate_vertex_attribute_from_edge method in ArmVariableRenderer. This involves renaming variables for clarity and ensuring proper handling of attribute values. Additionally, some test cases in TestYamlPolicies are commented out to focus on relevant tests.

TopicDetails
Memory Error Fix Refine the evaluate_vertex_attribute_from_edge method in ArmVariableRenderer to address memory errors by renaming variables for clarity and ensuring proper handling of attribute values.
Modified files (1)
  • checkov/arm/graph_builder/variable_rendering/renderer.py
Latest Contributors(1)
UserCommitDate
lirshindalmanfeat-arm-Add-arm-defin...October 30, 2024
Test Case Adjustment Comment out certain test cases in TestYamlPolicies to focus on relevant tests and streamline the testing process.
Modified files (1)
  • tests/arm/graph_builder/checks/test_yaml_policies.py
Latest Contributors(2)
UserCommitDate
taviassaffeat-azure-add-new-pol...November 17, 2024
SteveVakninfeat-azure-Add-policy-...June 02, 2024
This pull request is reviewed by Baz. Join @lirshindalman and the rest of your team on (Baz).

Copy link
Contributor

@SteveVaknin SteveVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@lirshindalman lirshindalman merged commit b6b5ce8 into main Nov 28, 2024
42 checks passed
@lirshindalman lirshindalman deleted the fix_memory_error_with_new_env branch November 28, 2024 07:20
Saarett pushed a commit that referenced this pull request Nov 28, 2024
* fix_memory error with adding new env

* fix_memory error with adding new env

* .

* .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants