-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(arm): Fix arm resource naming on integration with Prisma #6870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omriyoffe-panw
requested a deployment
to
scan-security
November 24, 2024 16:58
— with
GitHub Actions
Waiting
omriyoffe-panw
requested a deployment
to
scan-security
November 24, 2024 16:59
— with
GitHub Actions
Waiting
omriyoffe-panw
requested a deployment
to
scan-security
November 24, 2024 17:04
— with
GitHub Actions
Waiting
bo156
approved these changes
Nov 25, 2024
omriyoffe-panw
requested a deployment
to
scan-security
November 25, 2024 07:42
— with
GitHub Actions
Waiting
omriyoffe-panw
requested a deployment
to
scan-security
November 25, 2024 07:48
— with
GitHub Actions
Waiting
omriyoffe-panw
temporarily deployed
to
scan-security
November 25, 2024 08:03
— with
GitHub Actions
Inactive
OfekShimko
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Refactor the ARM resource naming logic to improve integration with Prisma by removing redundant filepath functions. The changes primarily affect the
ArmGraphManager
andRunner
classes, which handle the graph building and execution of ARM checks. Theget_files_definitions
function is now called without a custom filepath function, simplifying the code. Additionally, test cases inTestRunnerValid
have been updated to reflect these changes.TestRunnerValid
to align with the new ARM resource naming logic.Modified files (1)
Latest Contributors(2)
ArmGraphManager
andRunner
.Modified files (3)
Latest Contributors(2)