Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arm): Fix arm resource naming on integration with Prisma #6870

Merged
merged 13 commits into from
Nov 25, 2024

Conversation

omriyoffe-panw
Copy link
Contributor

@omriyoffe-panw omriyoffe-panw commented Nov 24, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Refactor the ARM resource naming logic to improve integration with Prisma by removing redundant filepath functions. The changes primarily affect the ArmGraphManager and Runner classes, which handle the graph building and execution of ARM checks. The get_files_definitions function is now called without a custom filepath function, simplifying the code. Additionally, test cases in TestRunnerValid have been updated to reflect these changes.

TopicDetails
Test Case Updates Update test cases in TestRunnerValid to align with the new ARM resource naming logic.
Modified files (1)
  • tests/arm/runner/test_runner.py
Latest Contributors(2)
UserCommitDate
gruebelbreak-general-remove-m...October 24, 2023
murbanski@paloaltonetw...add-tests-for-honoring...July 28, 2022
ARM Resource Naming Simplify the ARM resource naming logic by removing redundant filepath functions in ArmGraphManager and Runner.
Modified files (3)
  • checkov/arm/graph_manager.py
  • checkov/arm/runner.py
  • checkov/arm/utils.py
Latest Contributors(2)
UserCommitDate
omriyoffe-panwfix-arm-Fix-arm-graph-...November 24, 2024
taviassaffeat-azure-add-new-pol...November 17, 2024
This pull request is reviewed by Baz. Join @omriyoffe-panw and the rest of your team on (Baz).

@omriyoffe-panw omriyoffe-panw merged commit 24b17b1 into main Nov 25, 2024
42 checks passed
@omriyoffe-panw omriyoffe-panw deleted the fix-arm-breadcrumbs branch November 25, 2024 08:13
Saarett pushed a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants