Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code linting and full compliancy #210

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Code linting and full compliancy #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
f62223a
Initial jshint configuration following current/NPM style.
zenoamaro Dec 27, 2014
c545346
Removed trailing whitespace.
zenoamaro Dec 27, 2014
33617dd
Single space before everything, except function calls, as per NPM.
zenoamaro Dec 27, 2014
744a327
Converted to two-spaces indents as per @brianleroux in #208.
zenoamaro Dec 27, 2014
4ecbacb
No space before colon, single space after, except in inline objects.
zenoamaro Dec 27, 2014
04b9fc4
No space before comma, single space after.
zenoamaro Dec 27, 2014
98a927a
Spaces around operators in various cases.
zenoamaro Dec 27, 2014
0739a90
Removed spaces around parens, added spaces around curly braces.
zenoamaro Dec 27, 2014
40e87ff
Collapsed multiple empty lines.
zenoamaro Dec 27, 2014
b9e3641
Collapsed empty functions.
zenoamaro Dec 27, 2014
0661452
A bit more consistency in line spacing.
zenoamaro Dec 27, 2014
3a63697
Spacing after comments.
zenoamaro Dec 27, 2014
5e96e2a
Using single quotes only as per main project style.
zenoamaro Dec 27, 2014
5be8022
Fixed some brace spacing that I missed before.
zenoamaro Dec 27, 2014
bcf9703
Explicitly declaring globals and exports.
zenoamaro Dec 27, 2014
da05bd3
Fixed some accidental global leaks.
zenoamaro Dec 27, 2014
f89f485
Removed or otherwise explicitly allowing unused variables.
zenoamaro Dec 27, 2014
22146f1
Filtering own properties when looping over object keys.
zenoamaro Dec 27, 2014
07ad459
Strict comparisons using `===` and `!==` instead of `==` and `!=`.
zenoamaro Dec 27, 2014
bf77d95
Explicitly allowing some bitwise operators.
zenoamaro Dec 27, 2014
87ada2c
Better written as dot notation.
zenoamaro Dec 27, 2014
d798fd9
Confusing use of `!`.
zenoamaro Dec 27, 2014
9c399e0
Removed unnecessary semicolons.
zenoamaro Dec 27, 2014
a6f0b16
'Use strict' in main module, exporting explicitly.
zenoamaro Dec 27, 2014
52a4205
Strict mode in every source (inside immediates where necessary).
zenoamaro Dec 27, 2014
21fdce6
Explicit jshint fences for functions created in loops.
zenoamaro Dec 27, 2014
2d3f056
Marking some globals as read+write.
zenoamaro Dec 27, 2014
783109f
Misc fences for further compliancy.
zenoamaro Dec 27, 2014
6b8e5f9
Respecting limit of 80 chars per line, as per NPM style.
zenoamaro Dec 27, 2014
6fdec1b
Built library.
zenoamaro Dec 27, 2014
46109a4
Ugly cut in the middle of URLs :( this needs a solution
zenoamaro Dec 27, 2014
69996e6
Added lint step before tests in the makefile.
zenoamaro Dec 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions .jshintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
{
"browser": true,
"node": true,
"maxerr": 999,

"asi": true,
"bitwise": true,
"boss": false,
"camelcase": true,
"curly": false,
"debug": false,
"eqeqeq": true,
"eqnull": true,
"es3": true,
"es5": false,
"evil": true,
"expr": true,
"forin": true,
"freeze": true,
"funcscope": false,
"globalstrict": false,
"immed": true,
"indent": 2,
"iterator": false,
"lastsemic": true,
"latedef": false,
"laxbreak": true,
"laxcomma": true,
"loopfunc": false,
"maxcomplexity": false,
"maxdepth": 6,
"maxlen": 80,
"maxparams": 4,
"maxstatements": false,
"moz": false,
"newcap": true,
"noarg": true,
"nocomma": false,
"noempty": true,
"nonbsp": true,
"nonew": true,
"notypeof": true,
"noyield": false,
"phantom": false,
"plusplus": false,
"proto": false,
"quotmark": "single",
"scripturl": false,
"shadow": true,
"singleGroups": false,
"strict": true,
"sub": false,
"supernew": false,
"undef": true,
"unused": true,
"validthis": false,
"withstmt": false
}
Loading