Fix for field input text (#24)

* Change fixed height to ‘wrap_content’ for FieldInputText * Improve ‘setErrorText’ for FieldInputText when using ‘TextInputLayout’ * Fix ‘minHeight’ for ‘FieldInputText’ * Fix height for section title empty
brescia123 · Apr 11, 2017 · 865babd · 865babd
1 parent 111598a
commit 865babd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/main/java/it/facile/form/SectionedRecyclerViewAdapter.java b/src/main/java/it/facile/form/SectionedRecyclerViewAdapter.java
@@ -186,8 +186,8 @@ public void bind(PositionAwareSectionViewModel sectionViewModel) {
         }
 
         public int getHeight() {
-            return (int) (titleTextView.getText().length() == 0
-                                ? itemView.getResources().getDimension(R.dimen.section_height_small)
+            return (int) (titleTextView.getText().toString().trim().isEmpty()
+                                ? 0
                                 : getOriginalHeight());
         }
     }

diff --git a/src/main/res/layout/form_field_input_text.xml b/src/main/res/layout/form_field_input_text.xml
@@ -5,6 +5,7 @@
                                              android:background="@drawable/form_field_background"
                                              android:layout_width="match_parent"
                                              android:layout_height="wrap_content"
+                                             android:minHeight="@dimen/field_height_big"
                                              android:orientation="vertical">