Validate bolt11 network #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
force-pushed
the
savage-invalid-network
branch
from
6cb3d44 to
1458a99
Compare
dangeross
force-pushed
the
savage-invalid-network
branch
5 times, most recently
from
c221f32 to
d3a2e42
Compare
dangeross
force-pushed
the
savage-invalid-network
branch
from
d3a2e42 to
1510a1b
Compare
ok300
approved these changes
Nov 13, 2023
roeierez
requested changes
Nov 13, 2023
libs/sdk-core/src/invoice.rs
Outdated
| /// Parse a BOLT11 payment request and return a structure contains the parsed fields. | ||
| pub fn parse_invoice(bolt11: &str) -> InvoiceResult<LNInvoice> { | ||
| pub fn parse_invoice(bolt11: &str, network: Option<Network>) -> InvoiceResult<LNInvoice> { |
There was a problem hiding this comment.
This change makes the binding interface different than the rust interface (we added one parameter only to the rust layer).
I am not sure we should overload the upper layer validation down to this function. Perhaps we should validate on the caller instead?
dangeross
force-pushed
the
savage-invalid-network
branch
from
4459c20 to
0a20576
Compare
roeierez
reviewed
Nov 15, 2023
libs/sdk-core/src/invoice.rs
Outdated
| @@ -189,6 +195,25 @@ pub fn add_lsp_routing_hints( | |||
| Ok(invoice_builder.build_raw()?) | |||
| } | |||
|
|
|||
| // Validate that the BOLT11 payment request matches the network | |||
| pub fn validate_network(bolt11: &str, network: Network) -> InvoiceResult<()> { | |||
| if bolt11.trim().is_empty() { | |||
There was a problem hiding this comment.
We duplicate the parse_invoice code here. Perhaps we should just use it and compare the network with the LNInvoice object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the invoice network to the LNInvoice response of
parse_inputandparse_invoice. It also validates the bolt11 invoice network against the config network when callingsend_paymentorlnurl_pay.Fixes #462