Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parser_url placeholder #1147

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Change parser_url placeholder #1147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions libs/sdk-common/src/input_parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ use crate::prelude::*;
/// let external_parser = ExternalInputParser {
/// provider_id: "provider_id".to_string(),
/// input_regex: "(.*)(provider.domain)(.*)".to_string(),
/// parser_url: "http://external-parser-domain.com/{{input}}".to_string(),
/// parser_url: "http://external-parser-domain.com/<input>".to_string(),
/// };
///
/// let data = "151931provider.domain069135";
Expand Down Expand Up @@ -291,7 +291,7 @@ async fn parse_external(
// Build URL
let urlsafe_input =
percent_encoding::utf8_percent_encode(input, NON_ALPHANUMERIC).to_string();
let parser_url = parser.parser_url.replacen("{{input}}", &urlsafe_input, 1);
let parser_url = parser.parser_url.replacen("<input>", &urlsafe_input, 1);

// Make request
let parsed_value = match request_external_parsing(&parser_url).await {
Expand Down Expand Up @@ -773,7 +773,7 @@ pub struct ExternalInputParser {
pub provider_id: String,
/// The external parser will be used when an input conforms to this regex
pub input_regex: String,
/// The URL of the parser containing a placeholder `{{input}}` that will be replaced with the
/// The URL of the parser containing a placeholder `<input>` that will be replaced with the
/// input to be parsed. The input is sanitized using percent encoding.
pub parser_url: String,
}
Expand Down Expand Up @@ -1902,7 +1902,7 @@ pub(crate) mod tests {
let parsers = vec![ExternalInputParser {
provider_id: "id".to_string(),
input_regex: "(.*)(provider.domain)(.*)".to_string(),
parser_url: "http://127.0.0.1:8080/{{input}}".to_string(),
parser_url: "http://127.0.0.1:8080/<input>".to_string(),
}];

let input_type = parse(input, Some(&parsers)).await?;
Expand Down Expand Up @@ -1955,12 +1955,12 @@ pub(crate) mod tests {
ExternalInputParser {
provider_id: "bitcoin".to_string(),
input_regex: "(.*)(bitcoin.address.provider)(.*)".to_string(),
parser_url: "http://127.0.0.1:8080/{{input}}".to_string(),
parser_url: "http://127.0.0.1:8080/<input>".to_string(),
},
ExternalInputParser {
provider_id: "bolt11".to_string(),
input_regex: "(.*)(bolt11.provider)(.*)".to_string(),
parser_url: "http://127.0.0.1:8080/{{input}}".to_string(),
parser_url: "http://127.0.0.1:8080/<input>".to_string(),
},
];

Expand Down Expand Up @@ -1995,7 +1995,7 @@ pub(crate) mod tests {
let parsers = vec![ExternalInputParser {
provider_id: "id".to_string(),
input_regex: "(.*)(provider.domain)(.*)".to_string(),
parser_url: "http://127.0.0.1:8080/{{input}}".to_string(),
parser_url: "http://127.0.0.1:8080/<input>".to_string(),
}];

let result = parse(input, Some(&parsers)).await;
Expand Down
Loading