remove hibernation logic #1136
Merged
remove hibernation logic #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reconnect after hibernation does not fix the root cause of errors originating from lost grpc connections after hibernation. When the app comes back from hibernation, any already outgoing grpc request will fail with a transport error. The only way to get around that is by retrying the request. Also, grpc connections are automatically reestablished after such a failure occurs. If the grpc client gets a timeout or broken connection failure on one request, the next request will succeed with a fresh underlying connection.
dangeross
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reconnect after hibernation does not fix the root cause of errors originating from lost grpc connections after hibernation. When the app comes back from hibernation, any already outgoing grpc request will fail with a transport error. The only way to get around that is by retrying the request. Also, grpc connections are automatically reestablished after such a failure occurs. If the grpc client gets a timeout or broken connection failure on one request, the next request will succeed with a fresh underlying connection.
retrying requests is implemented in #1133