retry on any transport error with a source #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears many more error strings are seen than the ones specified in
BROKEN_CONNECTION_STRINGS. Among others:http2 error: connection error received: not a result of an errorconnection error: connection abortederror trying to connect: dns error: failed to lookup address information: No address associated with hostnameerror trying to connect: tcp connect error: Software caused connection abort (os error 103)error trying to connect: Software caused connection abort (os error 103)It appears there's a vast amount of different errors that can occur in the situation where the grpc channel would repair itself. Therefore retry on any transport error.