configure grpc connection for breez server #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JssDWt
reviewed
Nov 29, 2024
libs/sdk-common/src/breez_server.rs
Outdated
| Ok(Endpoint::from_shared(server_url.to_string())? | ||
| .http2_keep_alive_interval(Duration::new(5, 0)) | ||
| .tcp_keepalive(Some(Duration::from_secs(5))) | ||
| .http2_keep_alive_interval(Duration::from_secs(5)) |
|
For clippy rebase to main |
(cherry picked from commit a5073e73105e9265cacd3169c741e7209c03a596)
roeierez
force-pushed
the
configure_grpc_connection
branch
from
0a424e9 to
d4c6fae
Compare
JssDWt
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
LGTM
It might be that gl-client gets different keepalive settings: Blockstream/greenlight#548
I added a comment there: https://github.com/Blockstream/greenlight/pull/548/files#r1863998844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Breez grpc connection to recover from a stale connection in no more than 5 seconds. Previously it could take up to 20 seconds.