Add namespace to gradle files on Flutter plugin to be compatible with AGP 8.+ #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses warning: source/target value 8 is obsolete and will be removed in a future release.
dangeross
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Should we update the compileSdk/java version in libs/sdk-bindings/bindings-android and libs/sdk-react-native/android also or is it fine to leave them as is?
There was a problem hiding this comment.
Ideally yes, but scope of this PR only concerns Flutter plugin. Other bindings can be addressed in separate PRs if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses compatibility with Android Gradle Plugin (AGP) 8.+, the second error seen on issue #1128
Changelist
AndroidManifest.xml