-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagnostic data: include SDK version and git hash #1101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JssDWt good idea. I'll wait until you merge the JSON hex PR, then I'll rebase this one. |
I'm off until Friday, maybe you can include that commit in this PR for now. Just the commit that creates the json document, not the hex serializer. |
3b29c9f
to
c5a1ebf
Compare
I rebased on #1091 . |
35b19a9
to
ce23e32
Compare
c5a1ebf
to
d8b1400
Compare
* sdk-v0.6.2: update version to 0.6.2 use invoice destination for trampoline Bump gl-client to latest commit (#1106) Diagnostic data: include SDK version and git hash (#1101) trampoline: set max fee percent JSON serialize Vec<u8> fields as hex serialize diagnostic data as single json document Merge pull request #1102 from breez/optimize-claim-fetch fix error Merge pull request #1085 from breez/dependabot/npm_and_yarn/libs/sdk-react-native/example/serve-static-1.16.2 Merge pull request #1086 from breez/dependabot/npm_and_yarn/libs/sdk-react-native/serve-static-1.16.2 Optimize fetching claim tx by querying the lockup address Bump gl-client dependency (#1100) Strip ₿ prefix from lightning address
This PR adds the SDK version in the diagnostic data output: