Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic data: include SDK version and git hash #1101

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Oct 8, 2024

This PR adds the SDK version in the diagnostic data output:

***Version***
SDK v0.5.2 (23c25faac7)

@ok300 ok300 requested review from dangeross and JssDWt October 8, 2024 12:28
Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JssDWt
Copy link
Contributor

JssDWt commented Oct 8, 2024

@ok300 Is it an idea to rebase this PR on top of 6c30f3f?
That commit is uncontroversial I think, so let's at least make things json and figure out the hex encoding later?

@ok300
Copy link
Contributor Author

ok300 commented Oct 8, 2024

@JssDWt good idea. I'll wait until you merge the JSON hex PR, then I'll rebase this one.

@JssDWt
Copy link
Contributor

JssDWt commented Oct 8, 2024

@JssDWt good idea. I'll wait until you merge the JSON hex PR, then I'll rebase this one.

I'm off until Friday, maybe you can include that commit in this PR for now. Just the commit that creates the json document, not the hex serializer.

@ok300 ok300 force-pushed the ok300-diagnostic-incl-sdk-version branch from 3b29c9f to c5a1ebf Compare October 9, 2024 09:55
@ok300 ok300 changed the base branch from main to jssdwt-json-diagnostic October 9, 2024 09:56
@ok300
Copy link
Contributor Author

ok300 commented Oct 9, 2024

I rebased on #1091 .

@JssDWt JssDWt force-pushed the jssdwt-json-diagnostic branch from 35b19a9 to ce23e32 Compare October 11, 2024 09:16
Base automatically changed from jssdwt-json-diagnostic to main October 13, 2024 19:23
@ok300 ok300 force-pushed the ok300-diagnostic-incl-sdk-version branch from c5a1ebf to d8b1400 Compare October 13, 2024 19:25
@ok300 ok300 merged commit 677d22d into main Oct 13, 2024
9 checks passed
@ok300 ok300 deleted the ok300-diagnostic-incl-sdk-version branch October 13, 2024 19:59
DeanDonkov pushed a commit to DeanDonkov/breez-sdk that referenced this pull request Oct 21, 2024
roeierez added a commit that referenced this pull request Nov 1, 2024
* sdk-v0.6.2:
  update version to 0.6.2
  use invoice destination for trampoline
  Bump gl-client to latest commit (#1106)
  Diagnostic data: include SDK version and git hash (#1101)
  trampoline: set max fee percent
  JSON serialize Vec<u8> fields as hex
  serialize diagnostic data as single json document
  Merge pull request #1102 from breez/optimize-claim-fetch
  fix error
  Merge pull request #1085 from breez/dependabot/npm_and_yarn/libs/sdk-react-native/example/serve-static-1.16.2
  Merge pull request #1086 from breez/dependabot/npm_and_yarn/libs/sdk-react-native/serve-static-1.16.2
  Optimize fetching claim tx by querying the lockup address
  Bump gl-client dependency (#1100)
  Strip ₿ prefix from lightning address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants