Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: utilizando RegEX no arquivo phone.py #154

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

antoniamaia
Copy link
Member

Código refatorado utilizando regex nos métodos:

-is_valid_landline;
-is_valid_mobile;

Arquivos modificados:

  • phone.py;
  • README.md; (adicionado exemplo de input)
  • README_EN.md; (adicionado exemplo de input)

@antoniamaia antoniamaia self-assigned this Sep 12, 2023
@antoniamaia antoniamaia marked this pull request as ready for review September 12, 2023 19:55
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #154 (41ab7c5) into main (04619f6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           87        90    +3     
=========================================
+ Hits            87        90    +3     
Files Changed Coverage Δ
brutils/phone.py 100.00% <100.00%> (ø)

Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maravilhoooooso!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants