RUMBLE: now Trending shows also older videos and not repeat the newest

bravenewpipe · Sep 9, 2023 · bba0494 · bba0494
1 parent 61d23c3
commit bba0494
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/...habi/newpipe/extractor/services/rumble/extractors/RumbleCommonCodeTrendingAndChannel.java b/...habi/newpipe/extractor/services/rumble/extractors/RumbleCommonCodeTrendingAndChannel.java
@@ -50,8 +50,17 @@ public ListExtractor.InfoItemsPage<StreamInfoItem> extractAndGetInfoItemsFromPag
 
         final Page nextPage = rumbleCommonCodeTrendingAndSearching
                 .getNewPageIfThereAreMoreThanOnePageResults(
-                        infoItemsList.size(), doc, baseUrl + "?page=");
+                        infoItemsList.size(), doc, generateNextPageUrl(baseUrl, "page="));
 
         return new ListExtractor.InfoItemsPage<>(collector, nextPage);
     }
+
+    private String generateNextPageUrl(final String url,
+                                       final String pageParameter) {
+        if (url.contains("?")) {
+            // already parameterized -> append parameter
+            return url + '&' + pageParameter;
+        }
+        return url + '?' + pageParameter;
+    }
 }
diff --git a/...java/org/schabi/newpipe/extractor/services/rumble/extractors/RumbleTrendingExtractor.java b/...java/org/schabi/newpipe/extractor/services/rumble/extractors/RumbleTrendingExtractor.java
@@ -59,7 +59,7 @@ public InfoItemsPage<StreamInfoItem> getPage(final Page page)
         }
 
         doc = Jsoup.parse(getDownloader().get(
-                        getUrl(),
+                        page.getUrl(),
                         RumbleParsingHelper.getMinimalHeaders(),
                         NewPipe.getPreferredLocalization())
                 .responseBody());