Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade ubuntu and nodejs in github actions workflows #386

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

mihaiplesa
Copy link
Contributor

@mihaiplesa mihaiplesa commented Oct 31, 2024

To make it compatible with Node.js v22 which is the new active LTS.

@mihaiplesa mihaiplesa self-assigned this Oct 31, 2024
@mihaiplesa mihaiplesa requested a review from remusao as a code owner October 31, 2024 16:43
@remusao
Copy link
Collaborator

remusao commented Nov 2, 2024

These segfaults don't look too good. I'm curious why that's happening, we'll need to investigate before bumping Node.js to latest LTS.

@mihaiplesa mihaiplesa force-pushed the mplesa-ubuntu-nodejs-upgrade branch from 51fafb4 to f16acfe Compare December 16, 2024 16:39
@mihaiplesa mihaiplesa force-pushed the mplesa-ubuntu-nodejs-upgrade branch from f16acfe to 41d868e Compare January 22, 2025 14:21
Copy link

The following commits were not verified:
41d868e (unsigned)

Copy link
Collaborator

@remusao remusao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mihaiplesa

@remusao remusao merged commit 68ecd6b into main Jan 22, 2025
8 of 11 checks passed
@remusao remusao deleted the mplesa-ubuntu-nodejs-upgrade branch January 22, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants