Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PWA checks to desktop passes #404

Closed
wants to merge 1 commit into from
Closed

Adding PWA checks to desktop passes #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions wikitemplate-ReducedDesktop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,17 @@
- [ ] Verify that opening a NTP doesn't trigger any outbound connections related to widgets without user interaction
- [ ] Delete Adblock folder from browser profile and restart browser. Visit `brave://components` and verify `Brave Ad Block Updater` downloads and update the component. Repeat for all Brave components

#### PWA (Progressive Web Application)

- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` with `Open as window` selected creates a shortcut and launches a new window without any issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should be split into two. One where the site asks you to install the PWA and the one where you install a shortcut (Not actually a PWA).

Install App - https://twitter.com / https://youtube.com
Install Shortcut - https://cnn.com / https://brave.com

- [ ] ensure that a separate PWA window is being opened (this window will not have the URL bar visible)
- [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut
- [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update the test to mention it can be launched independent of browser process

- [ ] ensure that you can uninstall the PWA via `Hamburger Menu` -> `Uninstall PWA`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need another test for uninstalling the app via brave://apps which also allows to clear the site data during uninstall

- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` without `Open as window` selected creates a shortcut and creates a new tab
- [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut
- [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated. If the PWA is not created to launch as a separate window it will relaunch the browser process and open it in a new tab


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need another test for switching the site to PWA window from the main browser window

  • Verify visiting the site in normal browser window provides an option to launch in PWA window if installed as PWA/Shortcut.

### Upgrade

- [ ] Make sure that data from the last version appears in the new version OK
Expand All @@ -47,6 +58,7 @@
- [ ] Stored passwords are preserved
- [ ] Sync chain created in previous version is retained
- [ ] Social media blocking buttons changes are retained
- [ ] Previously created PWA shortcuts can still be used/launch without any issues
- [ ] Rewards
- [ ] Wallet balance is retained
- [ ] Auto-contribute list is retained
Expand Down
14 changes: 13 additions & 1 deletion wikitemplate-minorCRbumpDesktop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,18 @@

- [ ] Verify that you are able to successfully join Rewards on a fresh profile

## Update tests
#### PWA (Progressive Web Application)

- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` with `Open as window` selected creates a shortcut and launches a new window without any issues
- [ ] ensure that a separate PWA window is being opened (this window will not have the URL bar visible)
- [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

- [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed
- [ ] ensure that you can uninstall the PWA via `Hamburger Menu` -> `Uninstall PWA`
- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` without `Open as window` selected creates a shortcut and creates a new tab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous one

- [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous one

- [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed

### Update tests

- [ ] Verify visiting `brave://settings/help` triggers update check
- [ ] Verify once update is downloaded, prompts to `Relaunch` to install update
Expand All @@ -28,6 +39,7 @@
- [ ] Stored passwords are preserved
- [ ] Sync chain created in previous version is retained
- [ ] Social media blocking buttons changes are retained
- [ ] Previously created PWA shortcuts can still be used/launch without any issues
- [ ] Rewards
- [ ] Wallet balance is retained
- [ ] Auto-contribute list is retained
Expand Down
12 changes: 12 additions & 0 deletions wikitemplate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,17 @@
- [ ] Verify `Widevine Notification` is shown when you visit HBO Max for the first time
- [ ] Test that you can stream on HBO Max on a fresh profile after installing Widevine

#### PWA (Progressive Web Application)

- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` with `Open as window` selected creates a shortcut and launches a new window without any issues
- [ ] ensure that a separate PWA window is being opened (this window will not have the URL bar visible)
- [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut
- [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed
- [ ] ensure that you can uninstall the PWA via `Hamburger Menu` -> `Uninstall PWA`
- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` without `Open as window` selected creates a shortcut and creates a new tab
- [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut
- [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous one


### Geolocation

- [ ] Check that https://browserleaks.com/geo works and shows correct location
Expand Down Expand Up @@ -224,6 +235,7 @@
- [ ] Stored passwords are preserved
- [ ] Sync chain created in previous version is retained
- [ ] Social media-blocking buttons changes are retained
- [ ] Previously created PWA shortcuts can still be used/launch without any issues
- [ ] Rewards
- [ ] Wallet balance is retained
- [ ] Auto-contribute list is retained
Expand Down