Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Notes for iOS Release 1.73.97 #42713

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

Uni-verse
Copy link
Contributor

Resolves #42712

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

N/A

@Uni-verse Uni-verse added QA/No OS/iOS Fixes related to iOS browser functionality CI/skip labels Dec 6, 2024
@Uni-verse Uni-verse added this to the 1.73.x - Release #4 milestone Dec 6, 2024
@Uni-verse Uni-verse self-assigned this Dec 6, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Some small nit but other than that, looking good.

CHANGELOG_iOS.md Outdated Show resolved Hide resolved
CHANGELOG_iOS.md Outdated Show resolved Hide resolved
CHANGELOG_iOS.md Outdated Show resolved Hide resolved
CHANGELOG_iOS.md Outdated Show resolved Hide resolved
@Uni-verse
Copy link
Contributor Author

Looks great. Some small nit but other than that, looking good.

Thanks for reviewing. Changes are in.

@Uni-verse Uni-verse requested a review from kjozwiak December 9, 2024 22:01
@Uni-verse Uni-verse enabled auto-merge (squash) December 9, 2024 22:58
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice work.

@Uni-verse Uni-verse merged commit 63e1605 into master Dec 10, 2024
4 checks passed
@Uni-verse Uni-verse deleted the smesher-ios-release-notes-1.73.97 branch December 10, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip OS/iOS Fixes related to iOS browser functionality QA/No
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Notes for iOS Release 1.73.97
2 participants