-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New issue type for flatpak #40199
New issue type for flatpak #40199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: A brief description of the issue | ||
validations: | ||
required: true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd drop the empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This omits some of the questions from the desktop template, that would still be relevant. If we really want to have a dedicated template just for flatpak, it should cover the usual questions, I think.
We could consider a combined template for snap + flatpak. Idk, just a thought.
Do we need a separate issue template for this? For comparison, with Snap, we've just been using the The reason I'm asking is that I'm not sure a lot of users will pick that given how many different choices we have (see Wojciech's screenshot). |
A related thing that would help identify Flatpak users is #24327 Maybe we should also add it to the webcompat reporter. |
@fmarier my thinking here was that we're pointing users from the Flathub org to brave-core, so they would be looking for a Flatpak issue type, and for us, capturing that would be useful for triaging. I don't have strong opinions here though. Thinking about it more, I agree that #24327 would fix this problem. |
Closing in favour of #24327. |
Resolves #40198
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: