Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New issue type for flatpak #40199

Closed
wants to merge 1 commit into from
Closed

New issue type for flatpak #40199

wants to merge 1 commit into from

Conversation

ShivanKaul
Copy link
Collaborator

Resolves #40198

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the current order

image

I'd suggest a different position on the list - 5th between iOS and Feature request

This way per-platform issues would be first and then everything else would follow

description: A brief description of the issue
validations:
required: true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop the empty line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This omits some of the questions from the desktop template, that would still be relevant. If we really want to have a dedicated template just for flatpak, it should cover the usual questions, I think.

We could consider a combined template for snap + flatpak. Idk, just a thought.

@fmarier
Copy link
Member

fmarier commented Aug 1, 2024

Do we need a separate issue template for this? For comparison, with Snap, we've just been using the OS/Linux/Snap label and it's been okay.

The reason I'm asking is that I'm not sure a lot of users will pick that given how many different choices we have (see Wojciech's screenshot).

@fmarier
Copy link
Member

fmarier commented Aug 1, 2024

A related thing that would help identify Flatpak users is #24327

Maybe we should also add it to the webcompat reporter.

@ShivanKaul
Copy link
Collaborator Author

ShivanKaul commented Aug 1, 2024

@fmarier my thinking here was that we're pointing users from the Flathub org to brave-core, so they would be looking for a Flatpak issue type, and for us, capturing that would be useful for triaging. I don't have strong opinions here though.

Thinking about it more, I agree that #24327 would fix this problem.

@ShivanKaul
Copy link
Collaborator Author

Closing in favour of #24327.

@ShivanKaul ShivanKaul closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New issue type for flatpak
3 participants