Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adr): android 14 support #2695

Closed

Conversation

crherman7
Copy link
Contributor

@crherman7 crherman7 commented May 11, 2024

Describe your changes

Android 14 support.

It's advised against updating agp/kotlin versions outside of React Native updates: facebook/react-native#36974 (comment) and additionally it doesn't work either way as the gradle plugin was compiled with a specific kotlin version which will cause a mismatch compilation error.

The navigation library react-native-navigation must be minimally bumped to v7.37.2 for Android 14 support.

Ticket

Ticket

Type of change

  • New feature (non-breaking change which adds functionality)

Test Plan

  1. yarn install
  2. yarn build
  3. yarn test
  4. Verify pass
  5. cd apps/react-native
  6. yarn run init --platform android
  7. yarn android
  8. Verify run

Demo

android

Screenshot_1715403354

Checklist before requesting a review

  • A self-review of my code has been completed
  • Tests have been added / updated if required
  • Documentation has been updated to reflect these changes

@crherman7 crherman7 marked this pull request as draft May 11, 2024 04:57
@crherman7 crherman7 force-pushed the feat/android_14_code_12 branch from 9622ec2 to 3457c97 Compare May 11, 2024 05:01
@crherman7 crherman7 force-pushed the feat/android_14_code_12 branch from 3457c97 to 6171bc0 Compare May 11, 2024 05:03
@crherman7 crherman7 marked this pull request as ready for review May 11, 2024 05:04
@crherman7 crherman7 added the v12 label May 11, 2024
@crherman7 crherman7 closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant