Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fastlane): update ios compile lane #2655

Merged

Conversation

crherman7
Copy link
Contributor

@crherman7 crherman7 commented Mar 14, 2024

Describe your changes

Update ios compile lane in fastlane to skip code signing and archiving. The xcargs is no longer necessary.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • A self-review of my code has been completed
  • Tests have been added / updated if required
  • Documentation has been updated to reflect these changes

@crherman7 crherman7 force-pushed the feat/fastlane_ios_compile branch from 82984fa to 66e239f Compare March 14, 2024 19:42
@jasonmosley
Copy link
Collaborator

@NickBurkhartBB We found an issue when compiling without signing. We use this to test PRs with native dependence changes. We'll need this to be published.

@NickBurkhartBB NickBurkhartBB merged commit 4d33380 into brandingbrand:develop Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants