Skip to content

Commit

Permalink
Merge pull request #2763 from brandingbrand/fix/ENG-5789
Browse files Browse the repository at this point in the history
fix: ENG-5789 - Version pin xcproj and cocoapods for CI
  • Loading branch information
NickBurkhartBB authored Oct 29, 2024
2 parents 146a122 + 3845727 commit 45e72dd
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
9 changes: 7 additions & 2 deletions packages/cli/src/actions/packagers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,14 @@ export default defineAction(async (): Promise<void> => {
*/
if (canRunIOS(config.options)) {
try {
for await (const line of execa({
const podInstallOut = execa({
cwd: path.project.resolve('ios'),
})`pod install`) {
})(
isCI ? 'bundle' : 'pod',
isCI ? ['exec', 'pod', 'install'] : ['install'],
);

for await (const line of podInstallOut) {
logger.debug(line);
}

Expand Down
6 changes: 3 additions & 3 deletions packages/cli/templates/react-native-0.72/addons/ios/Gemfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source "https://rubygems.org"

# Cocoapods 1.15 introduced a bug which break the build. We will remove the upper
# bound in the template on Cocoapods with next React Native release.
gem 'cocoapods', '>= 1.13', '< 1.15'
# Cocoapods 1.16 requires xcodeproj 1.26.0, which is not compatible with React Native due to a bug.
gem 'cocoapods', '~> 1.15.0'
gem 'activesupport', '>= 6.1.7.5', '< 7.1.0'
gem 'xcodeproj', '~> 1.25.0'
6 changes: 3 additions & 3 deletions packages/cli/templates/react-native-0.73/addons/ios/Gemfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source "https://rubygems.org"

# Cocoapods 1.15 introduced a bug which break the build. We will remove the upper
# bound in the template on Cocoapods with next React Native release.
gem 'cocoapods', '>= 1.13', '< 1.15'
# Cocoapods 1.16 requires xcodeproj 1.26.0, which is not compatible with React Native due to a bug.
gem 'cocoapods', '~> 1.15.0'
gem 'activesupport', '>= 6.1.7.5', '< 7.1.0'
gem 'xcodeproj', '~> 1.25.0'

0 comments on commit 45e72dd

Please sign in to comment.