Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing model #56

Merged
merged 4 commits into from
May 31, 2024
Merged

fixing model #56

merged 4 commits into from
May 31, 2024

Conversation

djarecka
Copy link
Collaborator

  • fixing is_a for Donor class;
  • removing some slots from prov classes

@@ -15,31 +19,34 @@ default_range: string
subsets:
bican:
description: A subset of classes that are associated with BICAN.
from_schema: https://identifiers.org/brain-bican/kb-model
from_schema: https://identifiers.org/brain-bican/library-generation-schema
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's from_schema ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an additional id that is added by schemasheet
but seems like the error came from the subset that were added from biolink_bican (I've added imports to be added automatically by schemasheet). For now I will just remove it, and add to my script, and after workshop I can check it

@djarecka djarecka merged commit 956fe06 into brain-bican:main May 31, 2024
6 checks passed
@djarecka djarecka deleted the fix/model branch January 16, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants