Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Green Table Additions #20

Closed
wants to merge 50 commits into from

Conversation

puja-trivedi
Copy link
Collaborator

No description provided.

@satra
Copy link
Contributor

satra commented Oct 7, 2023

shouldn't this only add the yaml file? the rest should be auto generated on merge.

@puja-trivedi
Copy link
Collaborator Author

puja-trivedi commented Oct 7, 2023

@satra - if you look at the workflow it is generated on "push" as well as "pull request". Although it might make more sense to change it to "merge".

name: generating other formats

on:
  push:
  pull_request:

@satra
Copy link
Contributor

satra commented Oct 7, 2023

sorry i had forgotten. the conflicts misled me. yes, it would be good to test that the autogeneration works, but the actual autogeneration could happen when ready to merge, or when a label is set on the PR.

Puja Trivedi and others added 7 commits October 12, 2023 15:41
…ve orange boxes.

Added that GARS objects can either point to a reference object or just store that object's id (str).
Added that some orange boxes can have multiple inputs.
Will add back once issue is resolved.
@djarecka
Copy link
Collaborator

@puja-trivedi - perhaps you didn't pull the changes to autogenerated formats and that's why you have the conflicts?

Puja Trivedi and others added 2 commits October 20, 2023 13:10
Partially resolved type hints issue when inherting and importing classes from biolink. All slots except 'in_taxon' are resolved.
description: >-
Histone modification marker antibodies (eg H3K27ac, H3K27me3, H3K9me3) used in conjunction with an Enriched Cell Source Barcode in order to combine multiple Enriched Cell Populations before Barcoded Cell Sample step for 10xMultiome method.
Each of the Histone antibodies captures an essential part of the epigenome.
population:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be enrichment population?

@satra
Copy link
Contributor

satra commented Nov 1, 2023

@puja-trivedi - is this the latest version of the green sheets/minimal metadata release? (and could you please fix the conflicts?)

required: true
quantity fmol:
description: Amount of library pool in the tube as measured in femtamoles (fmol)
quantity pM:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be concentration instead of quantity?

@satra
Copy link
Contributor

satra commented Nov 7, 2023

go for it.

@puja-trivedi
Copy link
Collaborator Author

puja-trivedi commented Nov 8, 2023

the checks are currently failing due to a linkml issue.

Update: All checks are passing now (using the advice provided on the issue). Had to add "linkml-runtime == 1.6.0" to pyproject.toml temporarily to fix issue.

@djarecka djarecka closed this May 6, 2024
@puja-trivedi puja-trivedi deleted the notebook_additions branch November 22, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants