-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Green Table Additions #20
Conversation
shouldn't this only add the yaml file? the rest should be auto generated on merge. |
@satra - if you look at the workflow it is generated on "push" as well as "pull request". Although it might make more sense to change it to "merge".
|
sorry i had forgotten. the conflicts misled me. yes, it would be good to test that the autogeneration works, but the actual autogeneration could happen when ready to merge, or when a label is set on the PR. |
@puja-trivedi - perhaps you didn't pull the changes to autogenerated formats and that's why you have the conflicts? |
Partially resolved type hints issue when inherting and importing classes from biolink. All slots except 'in_taxon' are resolved.
description: >- | ||
Histone modification marker antibodies (eg H3K27ac, H3K27me3, H3K9me3) used in conjunction with an Enriched Cell Source Barcode in order to combine multiple Enriched Cell Populations before Barcoded Cell Sample step for 10xMultiome method. | ||
Each of the Histone antibodies captures an essential part of the epigenome. | ||
population: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be enrichment population
?
@puja-trivedi - is this the latest version of the green sheets/minimal metadata release? (and could you please fix the conflicts?) |
required: true | ||
quantity fmol: | ||
description: Amount of library pool in the tube as measured in femtamoles (fmol) | ||
quantity pM: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be concentration instead of quantity?
go for it. |
…models into notebook_additions
the checks are currently failing due to a linkml issue. Update: All checks are passing now (using the advice provided on the issue). Had to add "linkml-runtime == 1.6.0" to pyproject.toml temporarily to fix issue. |
No description provided.