Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto PR: assertion_evidence.yaml generated from google spreadsheets using schemasheets #126

Closed
wants to merge 2 commits into from

Conversation

puja-trivedi
Copy link
Collaborator

This PR adds a autogenerated assertion_evidence.yaml file.

@tekrajchhetri
Copy link
Contributor

tekrajchhetri commented Dec 13, 2024

Thanks @puja-trivedi for this. I observed the following.

  1. Disconnected class. Please note that these disconnected class should connect to Assertion. We could use properties, has_significance_level and has_significance (or significance_type).

image
image

  1. The assertion class should be connected to document and platform class with property is_expressed_in, which is not the case. Currently, it is connect with Thing class.

Expected:
image

Current:
image

Rest looks good to me and we can merge and this is our V1 draft.

@puja-trivedi
Copy link
Collaborator Author

puja-trivedi commented Dec 17, 2024

  • Issue 1 - Disconnected class (resolved in PR#127)
  • Issue 2 - Assertion,Document,Platform (this is an issue with the visualization tool; nothing to fix in the model)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants