-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto PR: assertion_evidence.yaml generated from google spreadsheets using schemasheets #123
Conversation
looking at the ER diagram, and there are couple connections that are not clear to me:
@tekrajchhetri -please comment |
IMO, agent participates_in activity is the appropriate relation |
@djarecka Please find my answer below.
The
We can include the
Yes, we agreed to replace |
Update: I checked the file and I can see the classes |
@@ -85,6 +123,12 @@ | |||
"title": "AssertionType", | |||
"type": "string" | |||
}, | |||
"AutomaticAssertion": { | |||
"additionalProperties": false, | |||
"description": "An assertion method that does not involve human review.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking, but with some exceptions, I would like to avoid descriptions that classify via negation. Could this be: "An assertion method that is made via an automated process."? Perhaps if this is intended only to cover in silico assertions, we could add a clause to that effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the google sheet with An assertion method executed automatically by machines without human intervention. definition. So next time when we generate the model, it should replace this negated definition.
@patrick-lloyd-ray - we don't see |
Oh, I was thinking in BFO/RO world. According to the RO->PROV mapping, it should be |
worked moved to #130 |
This PR adds a autogenerated assertion_evidence.yaml file.