Added support for 'line-no-highlight' class #49
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -495,12 +495,14 @@ public function process_gist_html( $html, array $args ) { | |
| //$classes[] = ( $key % 2 ) ? 'line-odd' : 'line-even'; | ||
| $style = ''; | ||
|
|
||
| if ( isset( $highlight[$key + 1] ) ) { | ||
| $classes[] = 'line-highlight'; | ||
|
|
||
| if ( ! empty( $args['highlight_color'] ) ) { | ||
| $style = ' style="background-color: ' . $args['highlight_color'] . ' !important"'; | ||
| } | ||
| } elseif ( ! empty( $args['highlight'] ) ) { | ||
|
There was a problem hiding this comment. Instead of checking There was a problem hiding this comment. Changing the There was a problem hiding this comment. It's been a while since I worked on this, and @bradyvercher might correct me, but the opening condition of:
...says that "if highlighting is to be applied to this line, then...", which means the else translates to "no highlighting should be applied to this line". Hang on. I'm going on the assumption that you're after the following. Some highlighting: .line .line-no-highlight No highlighting: .line .line-no-highlight But are you actually after: Some highlighting: .line .line-no-highlight No highlighting: .line ? Only adding the no-highlighting if there is at least one line which does have highlighting? In which case, what you've got would be correct. |
||
| $classes[] = 'line-no-highlight'; | ||
| } | ||
|
|
||
| /** | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When square brackets contain a variable, the extra spaces should be preserved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't maintain this within my IDE. The auto-formatting options in PHPStorm are simply have a space or don't have a space within brackets – there is no condition based on whether or not the content of brackets will be a variable, so I can never really accurately follow that particular piece of Wordpress coding standards. I'm wrong either way.
I'm just using the PHPStorm config settings maintained by Rarst - https://gist.github.com/Rarst/1370155