-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Carbon compatibility styles #937
Conversation
07ee419
to
cb42990
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, as a follow up it would be good to bring a table into the example test cases so that they can easily be seen via npm run start:carbon
(and also trigger our regression tests)
Maybe we could do this after #942
Ah only one thing missing I see actually, can you change the commit message to reference the base issue? We usually write |
I don't think it makes sense to link to the root issue if we have a split issue. The issue is also linked to the root issue. |
* feat: Add Carbon compatibility styles * test: Add Carbon tests
* feat: Add Carbon compatibility styles * test: Add Carbon tests
* chore: update dependency lerna to v8 (#914) * chore: update dependency lerna to v8 * deps: remove legacy lerna scripts Cf. https://lerna.js.org/docs/legacy-package-management --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Niklas Kiefer <[email protected]> Co-authored-by: Vinícius Goulart <[email protected]> * chore(CI): updated snapshots [skip ci] * deps: update dependency didi to v10 (#909) * deps: update dependency didi to v10 * chore: Bump to [email protected] --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vinicius Goulart <[email protected]> * chore(CI): updated snapshots [skip ci] * chore: Bump to [email protected] (#927) * deps: update dependency feelin to v3 (#941) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: Bump `schemaVersion` to 13 (#896) * chore: Bump schemaVersion to 13 * chore: Fix formatting Co-authored-by: Niklas Kiefer <[email protected]> * fix: Fix schema version range on docs * chore: Remove newline * feat: Make columns and columnsExpression mutually exclusive * feat: Add custom error message --------- Co-authored-by: Niklas Kiefer <[email protected]> * chore: Fix typos in comments * feat: Add table component to editor (#905) * feat: Add table component to editor * chore: Replace key with id * chore: Fix typo * feat: Add dataSource to schema * fix: Rework initialDemoData and add test * chore: Update formatting Co-authored-by: Niklas Kiefer <[email protected]> --------- Co-authored-by: Niklas Kiefer <[email protected]> * feat: Add table entries to properties panel (#912) * chore: Bump `schemaVersion` to 13 (#896) * chore: Bump schemaVersion to 13 * chore: Fix formatting Co-authored-by: Niklas Kiefer <[email protected]> * fix: Fix schema version range on docs * chore: Remove newline * feat: Make columns and columnsExpression mutually exclusive * feat: Add custom error message --------- Co-authored-by: Niklas Kiefer <[email protected]> * feat: Add table component to editor (#905) * feat: Add table component to editor * chore: Replace key with id * chore: Fix typo * feat: Add dataSource to schema * fix: Rework initialDemoData and add test * chore: Update formatting Co-authored-by: Niklas Kiefer <[email protected]> --------- Co-authored-by: Niklas Kiefer <[email protected]> * chore: Remove commented code * feat: Add table entries to properties panel * fix: Fix tooltip Co-authored-by: Niklas Kiefer <[email protected]> * chore: Rename id * feat: Use behavior to manage column headers * chore: Fix test description Co-authored-by: Niklas Kiefer <[email protected]> --------- Co-authored-by: Niklas Kiefer <[email protected]> * feat: Add table component to viewer (#920) * feat: Add table component to viewer * fix: Fix default rowCount * feat: Add generic data on editor view * fix: Refactor form field table styles * test: Add tests * fix: Turn data source into FEEL only * chore: Remove unnecessary new line * chore: Remove FEEL check on dataSource * chore: Sort by asc first * chore: Remove unnecessary label check * chore: Use const instead of let * fix: Create EditorTable * chore: Fix formatting * chore: Make label id optional * fix: Add row gap * fix: Add missing leftovers from table component (#938) * feat: Add Carbon compatibility styles (#937) * feat: Add Carbon compatibility styles * test: Add Carbon tests * feat: Add dynamic lists component (#808) * chore: rename expression-language folder * wip: implemented protoype repeatRenderManager * feat: `subform` component * feat: integrated prototype repeatRenderModule * feat: hooked up indexing to update cycle Related to #796 * feat: subform properties panel configuration Related to #796 * feat: added group styles to subform * feat: form initializer works with repeatable Related to #796 * chore: display key and path from config Related to #796 * feat: enforce path for repeatable groups Related to #796 * feat: adjusted getSubmitData for repeatable Related to #796 * feat: repeat render manager Closes #796 * chore: renamed subform to dynamic list Related to #796 * chore: adjusted path tooltip for repeating Related to #796 * feat: repeated element validation Related to #796 * wip: custom editor list renderer (missing icon) Related to #796 * wip: collapse / expand dynamic lists Related to #796 * feat: implement group/list alignment Related to #796 * chore: added empty states to group and list Related to #796 * feat: brought in new icons and matched visuals Related to #796 * fix: form root outline never shows * fix: editor no longer refreshes on element hover Closes #807 Related to #796 * feat: add/remove items in dynamic lists Related to #796 * feat: local expression contexts Related to #796 * feat: add/remove styles Related to #796 * feat: automatically scroll when adding item Related to #796 * feat: refine add/remove UX Related to #796 * chore: use karma-spec reporter for tests * chore: refactored viewer and editor tests Related to #808 * chore: large rebase test cleanups Related to #808 * fix(submit): only modify error object when needed Related to #808 * fix: final repeated subforms test adjustments Related to #808 * chore: fixed minor tabs and naming issues Related to #808 * feat: added carbon styles for dynamic list Related to #907 * fix: improved dynamic list button outlines Related to #808 * chore: rebase changes on `develop` * chore: reduced nesting and improved docs in Form.js core functions Related to #808 * chore: removed pointless useMemo Related to #808 * chore: cleanup remnants of ai generation Related to #808 * chore: switch from hardcoded to computed componentCount test Related to #808 * fix(performance): centralize variable filtering Related to https://github.com/camunda/tasklist/issues/3758 * chore: optimize svgs Related to #808 * feat: implemented proper path management for repeatable fields Related to #808 * fix: always expand when uncollapsible Related to #808 * fix: proper key change handling and repeatable filtering Related to #808 * feat: implement proper variable hiding within repeated field Related to #808 * chore: adjust table/iframe tests following rebase Related to #808 * fix: adjust numerical configs of dynamic list to prevent crashes Related to #808 * fix: properly split path replacements in pathEntry Related to #808 * fix: ensure dynamic list buttons don't submit Related to #808 * feat: Carbonise dynamic list * fix: show proper default uncollapsed items in propspan Related to #808 * feat(schema): added dynamic list component Related to #808 * chore(schema): adjust test indexes Related to #808 --------- Co-authored-by: Niklas Kiefer <[email protected]> Co-authored-by: Vinicius Goulart <[email protected]> * chore: update actions/setup-node digest to 7247617 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Niklas Kiefer <[email protected]> Co-authored-by: Vinícius Goulart <[email protected]> Co-authored-by: bpmn-io-bot <[email protected]> Co-authored-by: Valentin Serra <[email protected]>
Closes #936
form-js
element or visually changes an existing component.