feat: implemented separator form field #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The schemaVersion needs to be updated, right? And do you think we need dedicated Carbon styles for that one? Maybe at least for the color. |
|
@pinussilvestrus Ah yes the schema version true true. The color is set via the same variable as group borders, so it is adjusted for carbon, I checked and it looks totally fine. |
Related to #480
vsgoulart
reviewed
Oct 17, 2023
packages/form-js-editor/src/features/properties-panel/groups/GeneralGroup.js
Show resolved
Hide resolved
packages/form-js-viewer/src/render/components/icons/Separator.svg
Outdated
Show resolved
Hide resolved
pinussilvestrus
approved these changes
Oct 17, 2023
|
Oh, Tasklist Carbonization failed 👀 |
Related to #480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #480