fix: readonly number fields should not show controls #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #810 |
There was a problem hiding this comment.
@kerlon5 thanks a lot for your contribution!
What I'm wondering is that the number field is not distinguishable now with text fields in the read-only state. Also in in read-only, it might be interesting what data type this field has, although I can't edit it.
@bpmn-io/hto-dev @volodymyr-melnykc what do you think?
|
In the read-only mode, we don't need to show controls as the user can't interact with it, so I agree with the fix. If an input field has a "prefix" or "suffix" defined, we should still display it when in read-only. I believe that this remains the case (based on code updates). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #810