Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: commandStack.changed event provides context #528

Closed
wants to merge 1 commit into from
Closed

feat: commandStack.changed event provides context #528

wants to merge 1 commit into from

Conversation

PabloDons
Copy link

Which issue does this PR address?

Closes #479

Acceptance Criteria

  • Corresponds to the concept
  • Corresponds to the design

Definition of Done

@nikku
Copy link
Member

nikku commented Jan 21, 2021

Great. I did add some minor simplifications on top of your PR via 43512f4 and will go ahead and merge that one after I got your O.K.

Please double check the simplifications I made as well as my review comments.

@PabloDons
Copy link
Author

I have tested your simplifications and it works perfectly in my use case! 👍

@nikku
Copy link
Member

nikku commented Jan 22, 2021

Squashed and merged via #529.

Thanks for your contribution.

@nikku nikku closed this Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command stack change event should be more detailed.
2 participants