Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blog): add form-js@1 blog post #169

Merged
merged 4 commits into from
Dec 11, 2023
Merged

feat(blog): add form-js@1 blog post #169

merged 4 commits into from
Dec 11, 2023

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Oct 9, 2023

Closes #162
Depends on https://github.com/camunda/team-hto/issues/372

Note: This is a draft, as [email protected] is yet to be released (including dynamic lists). Feel free to provide early feedback ❤️

@pinussilvestrus pinussilvestrus requested review from vsgoulart, Skaiir, a team, marstamm and smbea and removed request for a team October 9, 2023 11:13
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 9, 2023
@pinussilvestrus pinussilvestrus requested a review from nikku October 9, 2023 11:13
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff already 🏅

src/blog/2023/005-form-js-1.x.md Outdated Show resolved Hide resolved
src/blog/2023/005-form-js-1.x.md Outdated Show resolved Hide resolved
</p>
</div>

Without manual work, dynamic lists enable the effortless generation of repetitive sets of form components, such as data tables or ordered lists.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also deserves a little rewrite.

Also, I believe we should mention that we generate magic variables in the feel contexts now that we can use to access data within the same repetition, I can write something for that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or if we don't want to go too deep in the technical, we can link a future documentation page "Learn to work with dynamic lists". Although I'm not sure how okay we are with linking the Camunda docs from the bpmn-io forum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's okay to cross-reference Camunda documentation when it provides helpful additions 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we could also link is example diagrams that show certain behaviors in use. I also consider to replace the stock form-js viewer in the demo with the playground; maybe we can even link examples there?

src/blog/2023/005-form-js-1.x.md Outdated Show resolved Hide resolved
@Skaiir
Copy link
Contributor

Skaiir commented Oct 9, 2023

Few comments on style / readability, and one missing thing worth mention. But obviously this is draft and 1.4 isn't out yet so no rush :D

@pinussilvestrus
Copy link
Contributor Author

We just decided not to release dynamic lists with v1.4 as we are currently blocked with that (FTO).

Still, this blog post will include dynamic lists as it fits into the theme of complex forms. I will update the blog post once we are ready with v1.5.

@nikku
Copy link
Member

nikku commented Dec 1, 2023

@Skaiir @vsgoulart Let's revisit this once the respective form-js library is released. It is a good knowledge source.

@bpmn-io bpmn-io deleted a comment from CLAassistant Dec 8, 2023
@Skaiir Skaiir requested review from nikku and Skaiir and removed request for Skaiir December 8, 2023 06:28
@Skaiir Skaiir marked this pull request as ready for review December 8, 2023 06:29
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 8, 2023
@barmac barmac self-requested a review December 11, 2023 08:43
@Skaiir Skaiir requested review from Skaiir and removed request for Skaiir December 11, 2023 08:59
@Skaiir Skaiir assigned Skaiir and unassigned pinussilvestrus Dec 11, 2023
@barmac barmac force-pushed the 162-form-js-blogpost branch from 53c12e1 to b210c96 Compare December 11, 2023 12:01
@barmac
Copy link
Member

barmac commented Dec 11, 2023

I rebased this on top of main.

@barmac
Copy link
Member

barmac commented Dec 11, 2023

I applied changes based on Grammarly's feedback. I believe we are ready to publish this blog post.

@barmac
Copy link
Member

barmac commented Dec 11, 2023

Great work @pinussilvestrus and @Skaiir!

@barmac barmac merged commit e21db65 into main Dec 11, 2023
3 checks passed
@barmac barmac deleted the 162-form-js-blogpost branch December 11, 2023 12:32
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 11, 2023
@barmac
Copy link
Member

barmac commented Dec 11, 2023

It works fine on staging: https://stage.bpmn.io/blog/posts/2023-form-js-1.5-recent-developments

Let's release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog about [email protected] versions
4 participants