Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating RcppArmadillo initialization #3

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Updating RcppArmadillo initialization #3

merged 1 commit into from
Sep 6, 2022

Conversation

eddelbuettel
Copy link
Contributor

Lieber Bernhard,

These six one-line changes update RcppArmadillo from the now
deprecated << initialization to brace initialization allowed since
C++11 and long been the minimal standard with R too. It would be
great if you could merge this, and release and updated package "in the
next little while" -- see the two prior emails I sent, and the
transition log at RcppCore/RcppArmadillo#391

Oh, and tested with CRAN 0.2-7 and GitHub 0.2-8.

Gruesse und Tschoe, Dirk

@eddelbuettel
Updating RcppArmadillo initialization
e075814 
These six one-line changes update RcppArmadillo from the now
deprecated `<<` initialization to brace initialization allowed since
C++11 and long been the minimal standard with R too.  It would be
great if you could merge this, and release and updated package "in the
next little while" -- see the two prior emails I sent, and the
transition log at RcppCore/RcppArmadillo#391
@eddelbuettel eddelbuettel mentioned this pull request Sep 4, 2022
Closed
31 tasks
@bpfaff
Copy link
Owner

bpfaff commented Sep 4, 2022 via email

@bpfaff bpfaff merged commit 132039c into bpfaff:master Sep 6, 2022
@bpfaff
Copy link
Owner

bpfaff commented Sep 6, 2022

Thank you so much, Dirk. An update to CRAN will be committed in due course. Best wishes, Bernhard

@eddelbuettel
Copy link
Contributor Author

Excellent. As you see over on the linked issue, it is not super urgen -- some are already there but other will take time. So fold it any updated you might have done any in the next little while. Of course, "done is done" so there is always something to be said to just getting TODOs out of the way...

@eddelbuettel eddelbuettel mentioned this pull request Jan 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpfaff bpfaff bpfaff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddelbuettel @bpfaff