many things #1
Open
many things #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Awesome, thanks for reaching out. I've not touched this in ages, but did have a few other ideas too. Will take a look through in the next couple of days and probably merge things in here. |
boyvinall
reviewed
Sep 1, 2024
| for i := range config.ScanDirs.Include { | ||
| j := i // copy loop variable | ||
| globPath := config.ScanDirs.Include[j] | ||
|
|
||
| if(string(globPath[len(globPath)-1:]) == "*"){ |
There was a problem hiding this comment.
I think we should just treat the path as a regular glob .. expand env vars first but then no need to special case this, just use filepath.Glob. Expand the globs in a separate function.
| @@ -37,6 +37,11 @@ func main() { | |||
| Usage: "Location of config file", | |||
| Value: getDefaultConfigPath(), | |||
| }, | |||
| &cli.BoolFlag{ | |||
| Name: "ignore_dir_errors", | |||
There was a problem hiding this comment.
I'm curious, what kinds of errors are coming up that you're ignoring?
|
|
||
| # if true, walking the directory tree underneath the `include` directories | ||
| # will traverse directories pointed to be symlinks | ||
| followsymlinks: true | ||
|
|
||
| edit_command: code %WORKING_DIRECTORY |
There was a problem hiding this comment.
%WORKING_DIRECTORY is a bit of a hack, maybe use text/template?
| .PHONY: build | ||
| build: install | ||
| build: | ||
| go build -o dirtygit main.go |
There was a problem hiding this comment.
useful to have linting and install at least
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I kind of stole your project. If you like the stuff I've been doing, feel free to contact me for a discussion about collaboration. Else big thanks for giving me a head start for a new project.
Cheers,
Pim